Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expr): support jsonb_populate_map #18378

Merged
merged 1 commit into from
Sep 4, 2024
Merged

feat(expr): support jsonb_populate_map #18378

merged 1 commit into from
Sep 4, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Sep 3, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

#17743

Support converting jsonb -> map by jsonb_populate_map(map,jsonb)->map. (This is similar to #13421)

  • Why not jsonb_to_map(jsonb)->map? Because we can't do the type inference (can't infer return type from the input type).
  • Why not cast(jsonb) -> map? This seems OK, but might increase the complexity of type inference. Cast is a deep dark area.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxchan xxchan mentioned this pull request Sep 3, 2024
19 tasks
@graphite-app graphite-app bot requested a review from a team September 3, 2024 09:51
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xxchan xxchan added this pull request to the merge queue Sep 4, 2024
Merged via the queue into main with commit c4b1dd4 Sep 4, 2024
39 of 42 checks passed
@xxchan xxchan deleted the xxchan/required-lark branch September 4, 2024 05:45
github-actions bot pushed a commit that referenced this pull request Sep 4, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants