fix(streaming): correctly retrieve initial split assignments from combined mutation for sink-into-table #18356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
xxchan
reviewed
Sep 2, 2024
| CREATE SINK table_sink INTO compact_table AS SELECT * FROM kafkasource; | ||
|
|
||
| system ok | ||
| echo '{ "id": 1, "name": "xxchan" }' | rpk topic produce test-topic-18308 |
xxchan
approved these changes
Sep 2, 2024
stdrc
approved these changes
Sep 2, 2024
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
This reverts commit d755e6a.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
…bined mutation for sink-into-table (#18356) Signed-off-by: Bugen Zhao <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
…bined mutation for sink-into-table (#18356) (#18388) Signed-off-by: Bugen Zhao <[email protected]> Co-authored-by: Bugen Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bugen Zhao [email protected]I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
The initial barrier is with
AddAndUpdatemutation for sink-into-table jobs. Previously we don't match against this variant when a source executor is initializing its splits, leading to data lost.Fix #18308.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.