Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disallow online scaling for shared source #18355

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Sep 2, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

xxchan commented Sep 2, 2024

@xxchan xxchan force-pushed the 08-24-refactor_use_high_watermark_to_finish_backfill_faster branch from d2bc71a to 051239b Compare September 2, 2024 08:08
@xxchan xxchan force-pushed the 09-02-feat_disallow_online_scaling_for_shared_source branch from 615340a to 86486a6 Compare September 2, 2024 08:08
@xxchan xxchan changed the base branch from 08-24-refactor_use_high_watermark_to_finish_backfill_faster to 08-16-feat_track_progress_for_sourcebackfill September 2, 2024 08:08
@xxchan xxchan force-pushed the 08-16-feat_track_progress_for_sourcebackfill branch from 2d650db to b3d554c Compare September 2, 2024 08:58
@xxchan xxchan force-pushed the 09-02-feat_disallow_online_scaling_for_shared_source branch from 86486a6 to c5b2e36 Compare September 2, 2024 08:58
@xxchan xxchan force-pushed the 08-16-feat_track_progress_for_sourcebackfill branch from b3d554c to a0ddd6d Compare September 2, 2024 09:08
@xxchan xxchan force-pushed the 09-02-feat_disallow_online_scaling_for_shared_source branch from c5b2e36 to ee78f3b Compare September 2, 2024 09:08
@xxchan xxchan closed this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant