Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compaction): support recreate block stream for fast compact iter #18350

Merged
merged 8 commits into from
Sep 3, 2024

Conversation

Li0k
Copy link
Contributor

@Li0k Li0k commented Sep 2, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Before finish rebuilding the stream at the object store level, I want to make sure that fast compaction is robust by using a workaround.

So, this PR has a few changes.

  1. support recreate stream for fast compact iter
  2. fix remote_io metrics
  3. add fail point test

fix #17962

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM! Thanks for the fix.

@Li0k
Copy link
Contributor Author

Li0k commented Sep 3, 2024

#15973

@Li0k Li0k enabled auto-merge September 3, 2024 04:10
@Li0k Li0k added this pull request to the merge queue Sep 3, 2024
Merged via the queue into main with commit 9d6515b Sep 3, 2024
29 of 30 checks passed
@Li0k Li0k deleted the li0k/storage_recreate_stream_for_fast_compact branch September 3, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add streaming read retry for fast compaction
2 participants