Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sink): fix sink_decouple = false and commit_checkpoint_interval defalut = 1; #18348

Merged
merged 10 commits into from
Sep 11, 2024

Conversation

xxhZs
Copy link
Contributor

@xxhZs xxhZs commented Sep 2, 2024

fix ci

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

in this pr;
if sink_decouple = true/defalut default commit_checkpoint_interval = 10;
if sink_decouple = false default commit_checkpoint_interval = 1;
if sink_decouple = false and set commit_checkpoint_interval > 1 return error

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

fix ci
@github-actions github-actions bot added the type/fix Bug fix label Sep 3, 2024
fix comm
@xxhZs xxhZs force-pushed the xxh/commit_checkpoint_interval_sink_decouple branch from 3c9e4a6 to 07cc7e4 Compare September 3, 2024 04:08
@graphite-app graphite-app bot requested a review from a team September 3, 2024 04:50
@xxhZs xxhZs requested a review from chenzl25 September 5, 2024 06:58
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This PR set the commit_checkpoint_interval for sinks in frontend.

@xxhZs xxhZs enabled auto-merge September 6, 2024 09:46
@xxhZs xxhZs added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit 5065bb4 Sep 11, 2024
39 of 40 checks passed
@xxhZs xxhZs deleted the xxh/commit_checkpoint_interval_sink_decouple branch September 11, 2024 13:06
xxhZs added a commit that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment