-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sink): fix sink_decouple = false and commit_checkpoint_interval defalut = 1; #18348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxhZs
added
ci/run-e2e-iceberg-sink-tests
ci/run-e2e-clickhouse-sink-tests
ci/run- e2e-deltalake-sink-rust-tests
ci/run-e2e-redis-sink-tests
ci/run-e2e-starrocks-sink-tests
ci/run-e2e-cassandra-sink-tests
ci/run-e2e-sink-tests
ci/run-e2e-mqtt-sink-tests
ci/run-e2e-mongodb-sink-tests
ci/run-e2e-sqlserver-sink-tests
and removed
type/fix
Bug fix
labels
Sep 2, 2024
hzxa21
reviewed
Sep 2, 2024
xxhZs
force-pushed
the
xxh/commit_checkpoint_interval_sink_decouple
branch
from
September 3, 2024 04:08
3c9e4a6
to
07cc7e4
Compare
chenzl25
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This PR set the commit_checkpoint_interval
for sinks in frontend.
hzxa21
approved these changes
Sep 5, 2024
xxhZs
added a commit
that referenced
this pull request
Sep 12, 2024
Merged
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci/run- e2e-deltalake-sink-rust-tests
ci/run-e2e-clickhouse-sink-tests
ci/run-e2e-iceberg-sink-tests
ci/run-e2e-mongodb-sink-tests
ci/run-e2e-mqtt-sink-tests
ci/run-e2e-redis-sink-tests
ci/run-e2e-sink-tests
ci/run-e2e-sqlserver-sink-tests
ci/run-e2e-starrocks-sink-tests
need-cherry-pick-release-2.0
type/fix
Bug fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix ci
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
in this pr;
if sink_decouple = true/defalut default commit_checkpoint_interval = 10;
if sink_decouple = false default commit_checkpoint_interval = 1;
if sink_decouple = false and set commit_checkpoint_interval > 1 return error
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.