feat: upgrade foyer to 0.11.3 #18313
Conversation
Signed-off-by: MrCroxx <[email protected]>
|
cc @BugenZhao for the opentelemetry and tonic part. |
Cargo.toml
Outdated
| @@ -78,7 +78,10 @@ license = "Apache-2.0" | |||
| repository = "https://github.com/risingwavelabs/risingwave" | |||
|
|
|||
| [workspace.dependencies] | |||
| foyer = { version = "0.10.4", features = ["nightly", "mtrace"] } | |||
| foyer = { git = "https://github.com/foyer-rs/foyer", rev = "f8eae8c", features = [ | |||
There was a problem hiding this comment.
Let me first build an image of this PR. If everything works fine, I'll bump foyer version, otherwise I need to fix bugs first.
Cargo.lock
Outdated
| @@ -5353,7 +5384,7 @@ dependencies = [ | |||
| "http 0.2.9", | |||
| "thiserror", | |||
| "tokio", | |||
| "tonic 0.10.2", | |||
| "tonic 0.11.0", | |||
There was a problem hiding this comment.
I guess this should be manually reverted
| @@ -171,9 +171,13 @@ reclaimers = 4 | |||
| recover_concurrency = 8 | |||
| insert_rate_limit_mb = 0 | |||
| indexer_shards = 64 | |||
| compression = "none" | |||
| compression = "None" | |||
There was a problem hiding this comment.
Is lower cased string still supported? (I don't care. Just ask)
There was a problem hiding this comment.
No, but I think nobody is using this field for now. And none is the default configuration. It's okay to switch to serde defauts now.
There was a problem hiding this comment.
case-insensive config is slightly more user-friendly to me (both OK). But it seems other options (like algorithm = "Lru", recover_mode = "None") are also case-sensive, so might be better to keep them consistent.
Signed-off-by: MrCroxx <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
Cargo.toml
Outdated
| @@ -181,10 +184,10 @@ tikv-jemallocator = { git = "https://github.com/risingwavelabs/jemallocator.git" | |||
| "stats", | |||
| ], rev = "64a2d9" } | |||
| # TODO(http-bump): bump to use tonic 0.12 once minitrace-opentelemetry is updated | |||
Cargo.toml
Outdated
| @@ -78,7 +78,10 @@ license = "Apache-2.0" | |||
| repository = "https://github.com/risingwavelabs/risingwave" | |||
|
|
|||
| [workspace.dependencies] | |||
| foyer = { version = "0.10.4", features = ["nightly", "mtrace"] } | |||
| foyer = { git = "https://github.com/foyer-rs/foyer", rev = "7eeb783", features = [ | |||
There was a problem hiding this comment.
There's no release on crates.io?
There was a problem hiding this comment.
Here. 🤣 I'm waiting for all related bugs are fixed.
Signed-off-by: MrCroxx <[email protected]>
|
longevity passed without error. buildkite: https://buildkite.com/risingwave-test/longevity-test/builds |
Q7 regression. Let me check |
Signed-off-by: MrCroxx <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
Signed-off-by: MrCroxx <[email protected]>
MrCroxx
changed the title
|
Performance issue solved. FYI: foyer-rs/foyer#708 
|
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.