Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sink): use official default message_timeout_ms #18304

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Aug 28, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Currently, if user does not specify the properties.message.timeout.ms in the options, the default message timeout is 5 seconds, which seems too small. In this PR, we will not explicitly set a default value for this property when not specified, and the default value will be used.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

In this PR, we change the default behavior of kafka sink message timeout when properties.message.timeout.ms is not explicitly specified when creating a sink. Previously, the default message timeout was 5 seconds. After this PR, we will change it to the 5 minutes, which is the default value of the official kafka library.

Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please also note the default timeout value

@wenym1 wenym1 added the user-facing-changes Contains changes that are visible to users label Aug 29, 2024
@wenym1 wenym1 added this pull request to the merge queue Aug 29, 2024
Merged via the queue into main with commit 242dbff Aug 29, 2024
36 of 37 checks passed
@wenym1 wenym1 deleted the yiming/kafka-sink-default-message-timeout branch August 29, 2024 05:26
github-merge-queue bot pushed a commit that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants