feat(sink): use official default message_timeout_ms #18304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Currently, if user does not specify the
properties.message.timeout.ms
in the options, the default message timeout is 5 seconds, which seems too small. In this PR, we will not explicitly set a default value for this property when not specified, and the default value will be used.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
In this PR, we change the default behavior of kafka sink message timeout when
properties.message.timeout.ms
is not explicitly specified when creating a sink. Previously, the default message timeout was 5 seconds. After this PR, we will change it to the 5 minutes, which is the default value of the official kafka library.