Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): remove shared buffer compaction grouped payload #18277

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

Li0k
Copy link
Contributor

@Li0k Li0k commented Aug 27, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

After #18053, hummock can split CN submitted ssts based on table stats, so there is no longer the problem of multiple compaction groups being interfered with due to inaccurate sizes.

So we can remove the logic of submitting ssts by compaction group on the CN side to reduce logic complexity and upload iops. This isn't a radical optimization , but I think it simplifies the logic on the CN side and is worth making as a separate change.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@Li0k Li0k requested review from wenym1, hzxa21 and zwang28 and removed request for wenym1 August 27, 2024 14:21
@Li0k Li0k changed the title feat(storage): remove shared buffer grouped payload feat(storage): remove shared buffer compaction grouped payload Aug 27, 2024
@Li0k
Copy link
Contributor Author

Li0k commented Aug 27, 2024

Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wenym1 wenym1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Li0k Li0k added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit ee77691 Aug 28, 2024
38 of 39 checks passed
@Li0k Li0k deleted the li0k/storage_remove_grouped_payload branch August 28, 2024 06:52
@Li0k
Copy link
Contributor Author

Li0k commented Sep 3, 2024

#15973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants