Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add license to file sink #18227

Merged
merged 1 commit into from
Aug 26, 2024
Merged

chore: add license to file sink #18227

merged 1 commit into from
Aug 26, 2024

Conversation

lmatz
Copy link
Contributor

@lmatz lmatz commented Aug 25, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

main PR #17311

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@graphite-app graphite-app bot requested a review from a team August 25, 2024 14:05
@lmatz lmatz requested review from hzxa21 and wcy-fdu August 25, 2024 14:43
@wcy-fdu
Copy link
Contributor

wcy-fdu commented Aug 25, 2024

Just to confirm, we will include file sink as a paid feature?

Copy link
Contributor

@wcy-fdu wcy-fdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the change.

@lmatz lmatz added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit 07911cf Aug 26, 2024
37 of 38 checks passed
@lmatz lmatz deleted the lz/file_sink_license branch August 26, 2024 05:20
github-actions bot pushed a commit that referenced this pull request Aug 26, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 26, 2024
kwannoel pushed a commit that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants