Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): visualize average backpressure rather than spot backpressure #18219

Merged
merged 4 commits into from
Aug 24, 2024

format

553fab1
Select commit
Loading
Failed to load commit list.
Merged

feat(dashboard): visualize average backpressure rather than spot backpressure #18219

format
553fab1
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed Started 2024-08-24 08:21:47 ago

0 / 8 tasks completed

8 tasks still to be completed

Details

Required Tasks

Task Status
Poll the actor_buffer_output_blocking_ns metric from meta / prometheus at a fixed duration (5s). Incomplete
After polling, get the difference between previous and current blocking_duration. Incomplete
Then backpressure rate is calculated as: Incomplete
This means if the blocking duration is a few minutes, it will show up on the graph for 5s, but in the subsequent epoch, it shows up 0, since actor_buffer_output_blocking_ns will ONLY be incremented after the chunk has been yielded downstream. Incomplete
It is very easy to miss as a result, and does not reflect the stuck state of the actor. This becomes worse if the stream job contains a large number of fragments. Incomplete
I have written necessary rustdoc comments Incomplete
I have added necessary unit tests and integration tests Incomplete
I have added test labels as necessary. See details. Incomplete
I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934). Incomplete
My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future). Incomplete
All checks passed in ./risedev check (or alias, ./risedev c) Incomplete
My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details) Incomplete
My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users) Incomplete