-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(suscription): Improving usability of subscription #18217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to modify the cursor test as well?
Rest LGTM!
PgFieldDescriptor::new( | ||
"Name".to_string(), | ||
DataType::Varchar.to_oid(), | ||
DataType::Varchar.type_len(), | ||
), | ||
PgFieldDescriptor::new( | ||
"SubscriptionName".to_string(), | ||
DataType::Varchar.to_oid(), | ||
DataType::Varchar.type_len(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is more useful to include the following information as well:
seek_pos
: the rw_timestamp or the the seek mode (FULL/BEGIN/NOW/...) when the cursor is declarenum_rows_fetched
: number of rows fetched internally by subscription cursornum_rows_returned
: number of rows returned to user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do this in a separate PR as well to speed up merging this PR with breaking changes to 2.0.
Co-authored-by: Xinhao Xu <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
#18208
show cursors
andshow subscription cursors
:show cursors
will return all query cursor in this seesionshow subscription cursors
will return all subscription cursor and subscription name in this seesionChecklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
after this pr
DECLARE cursor_name SUBSCRIPTION CURSOR
=DECLARE cursor_name SUBSCRIPTION CURSOR since now()
, will be consumed from the current time.DECLARE cursor_name SUBSCRIPTION CURSOR FULL
, Will start consuming data from stockInsert
Delete
UpdateInset
UpdateDelete
.show cursors
will return all query cursor in this seesionshow subscription cursors
will return all subscription cursor and subscription name in this seesion