refactor(iceberg): Separate iceberg source pb from source pb #18209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenzl25
reviewed
Aug 23, 2024
proto/batch_plan.proto
Outdated
Comment on lines
69
to
75
| message IcebergSourceNode { | ||
| uint32 source_id = 1; | ||
| repeated plan_common.ColumnCatalog columns = 2; | ||
| map<string, string> with_properties = 3; | ||
| repeated bytes split = 4; | ||
| map<string, secret.SecretRef> secret_refs = 5; | ||
| } |
There was a problem hiding this comment.
Let's change it to IcebergScanNode and keep only the necessary information like 'columns' and with_properties.
chenzl25
approved these changes
Aug 27, 2024
src/frontend/src/scheduler/local.rs
Outdated
| PlanNodeType::BatchIcebergScan => { | ||
| let mut node_body = execution_plan_node.node.clone(); | ||
| match &mut node_body { | ||
| NodeBody::IcebergScan(ref mut iceberg_source_node) => { |
There was a problem hiding this comment.
iceberg_source_node => iceberg_scan_node
| } | ||
| PlanNodeType::BatchIcebergScan => { | ||
| let node_body = execution_plan_node.node.clone(); | ||
| let NodeBody::IcebergScan(mut iceberg_source_node) = node_body else { |
There was a problem hiding this comment.
iceberg_source_node => iceberg_scan_node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Because iceberg souce is unique to batch, it is separated from source pb for subsequent development
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.