fix(meta): correctly persist license key system param in SQL backend #18163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
commented
Aug 21, 2024
Comment on lines
+338
to
+339
| params.$field = Some(v.into()); // do not use `to_string` to avoid writing redacted values | ||
| let new_value = params.$field.as_ref().unwrap().to_string(); // can now use `to_string` on protobuf primitive types |
There was a problem hiding this comment.
Highlight the core changes
|
Seems like #17936 is included in |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
…18163) Signed-off-by: Bugen Zhao <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
…18163) (#18164) Signed-off-by: Bugen Zhao <[email protected]> Co-authored-by: Bugen Zhao <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Follow-up of #17936.
Previously the
new_value: Stringreturned byset_system_paramis redacted forlicense_key, which will be further used to persist into the SQL backend. This is not expected. This PR fixes that and adds a unit test to clarify the semantics of the returnedStringtype value.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.