-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(source): parquet file source use number of rows to determine the end of the file reading #18149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxchan
reviewed
Aug 21, 2024
9 tasks
tabVersion
approved these changes
Aug 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hzxa21
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments. Rest LGTM
wcy-fdu
added
need-cherry-pick-release-1.10
Open a cherry-pick PR to branch release-1.10 after the current PR is merged
need-cherry-pick-release-2.0
labels
Aug 26, 2024
hzxa21
reviewed
Aug 26, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Aug 29, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Aug 29, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
…end of the file reading (#18149)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 30, 2024
…end of the file reading (#18149) (#18314) Co-authored-by: congyi wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
need-cherry-pick-release-1.10
Open a cherry-pick PR to branch release-1.10 after the current PR is merged
need-cherry-pick-release-2.0
type/fix
Bug fix
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
For parquet file source, we use
RecordBatchStream
to read parquet file, and it's offset represents the current row read, not the bytes. The fetch executor determines whether a file has been read completely by comparing the offset with the file size, where the file size is obtained during the list process.This pr modifies the semantics of the size of OpendalFsSplit in the parquet file, expressing it as the total number of rows in a parquet file. Specifically, before constructing OpendalFsSplit each time a file name is obtained, the metadata of the parquet file is read to obtain the total number of rows.
Todo:
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.