Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flaky udf e2e error ui test #18132

Merged
merged 2 commits into from
Aug 20, 2024
Merged

fix: flaky udf e2e error ui test #18132

merged 2 commits into from
Aug 20, 2024

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Aug 20, 2024 •
edited
Loading

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

To further fix #18118 (comment)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@stdrc
fix flaky udf e2e test
1f12741 
Signed-off-by: Richard Chien <[email protected]>
@stdrc stdrc requested review from BugenZhao and KeXiangWang August 20, 2024 08:20
@github-actions github-actions bot added the type/fix Bug fix label Aug 20, 2024
@graphite-app graphite-app bot requested a review from a team August 20, 2024 08:49
@xxchan xxchan added need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged need-cherry-pick-release-2.0 labels Aug 20, 2024
@xxchan xxchan enabled auto-merge August 20, 2024 14:27
This was referenced Aug 20, 2024
Closed
Closed
@xxchan xxchan added this pull request to the merge queue Aug 20, 2024
Merged via the queue into main with commit 6d8abb7 Aug 20, 2024
39 of 40 checks passed
@xxchan xxchan deleted the rc/fix-flaky-udf-test branch August 20, 2024 14:55
github-actions bot pushed a commit that referenced this pull request Aug 20, 2024
@stdrc @xxchan
fix: flaky udf e2e error ui test (#18132)
38cb0db 
Signed-off-by: Richard Chien <[email protected]>
Co-authored-by: xxchan <[email protected]>
This was referenced Aug 20, 2024
Merged
Closed
github-merge-queue bot pushed a commit that referenced this pull request Aug 20, 2024
@github-actions @stdrc @xxchan
fix: flaky udf e2e error ui test (#18132) (#18146)
8609922 
Signed-off-by: Richard Chien <[email protected]>
Co-authored-by: Richard Chien <[email protected]>
Co-authored-by: xxchan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxchan xxchan xxchan approved these changes

@BugenZhao BugenZhao BugenZhao approved these changes

@KeXiangWang KeXiangWang Awaiting requested review from KeXiangWang

Assignees
No one assigned
Labels
need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged need-cherry-pick-release-2.0 type/fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stdrc @BugenZhao @xxchan