You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enum is stored as string instead of number with sea-orm. Resolve#18113.
Checklist
I have written necessary rustdoc comments
I have added necessary unit tests and integration tests
All checks passed in ./risedev check (or alias, ./risedev c)
Documentation
My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.
Not sure why it was not covered by the e2e-single-node-tests in #18022.
Oh, I know why. Single node uses Sqlite, which allows string and int comparison. 🥵
So sea-orm or sea-query does not completely erase the difference between backends. 🥵 Perhaps we need to consider testing against all supported backends in CI.
Not sure why it was not covered by the e2e-single-node-tests in #18022.
Oh, I know why. Single node uses Sqlite, which allows string and int comparison. 🥵
So sea-orm or sea-query does not completely erase the difference between backends. 🥵 Perhaps we need to consider testing against all supported backends in CI.
Yes, I will switch all CI tests for PR to sqlite recently and we can test all backends in main-cron job.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
enumis stored as string instead of number with sea-orm. Resolve #18113.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.