Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom kafka group id prefix #18115

Merged
merged 7 commits into from
Aug 21, 2024
Merged

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Aug 20, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

fix #17657
follow up of #16111

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

Add new config group.id.prefix for Kafka source.

See comment on the code for doc.

@xxchan xxchan force-pushed the xxchan/welcome-armadillo branch from 2345d6d to 2da639f Compare August 20, 2024 03:15
Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the impl LGTM, is there a request to customize the prefix?

@xxchan
Copy link
Member Author

xxchan commented Aug 20, 2024

There were some from time to time. To clean the backlog.

@xxchan xxchan enabled auto-merge August 20, 2024 03:30
@xxchan xxchan added this pull request to the merge queue Aug 21, 2024
@graphite-app graphite-app bot requested a review from a team August 21, 2024 02:56
Merged via the queue into main with commit ac655ea Aug 21, 2024
29 of 30 checks passed
@xxchan xxchan deleted the xxchan/welcome-armadillo branch August 21, 2024 02:57
github-actions bot pushed a commit that referenced this pull request Aug 21, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 21, 2024
@pjpringlenom
Copy link

I raised a similar request for pulsar connector consumer id prefix on slack.

@xxchan
Copy link
Member Author

xxchan commented Sep 5, 2024

I raised a similar request for pulsar connector consumer id prefix on slack.

I see @tabVersion is doing it: #18377

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

allow custom kafka consumer group id
4 participants