-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support custom kafka group id prefix #18115
Conversation
2345d6d
to
2da639f
Compare
Signed-off-by: xxchan <[email protected]>
2da639f
to
b710953
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the impl LGTM, is there a request to customize the prefix?
There were some from time to time. To clean the backlog. |
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]> Co-authored-by: xxchan <[email protected]>
I raised a similar request for pulsar connector consumer id prefix on slack. |
I see @tabVersion is doing it: #18377 |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
fix #17657
follow up of #16111
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
Add new config
group.id.prefix
for Kafka source.See comment on the code for doc.