test(mssql-cdc): enrich tests and small refactor #18081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikeW
reviewed
Aug 19, 2024
xxchan
reviewed
Aug 19, 2024
| * | ||
| ) from mssql_source table 'dbo.sqlserver_all_data_types'; | ||
|
|
||
| sleep 5s |
There was a problem hiding this comment.
What's the intention of the sleep here? create - sleep - drop looks a little weird.
There was a problem hiding this comment.
Previously, I found if the types found by (*) are wrongly converted to RW types, RW will crash explicitly when consuming the data in the upstream table. I've fixed the found mismatch in this PR. This test sleep 5s is to ensure the data is consumed and the mismatch is encountered so that it can be exposed.
|
Shall we pick this PR to release-2.0? |
Yes, I think so. I'll confirm with jianwei. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
Co-authored-by: Kexiang Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Add tests for
INCLUDESRefactor:
SELECT * FROM {} WHERE 1 = 0toINFORMATION_SCHEMA.COLUMNS-based SQL.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.