Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stream): fix functional dependencies for row merge #18072

Merged
merged 2 commits into from
Aug 17, 2024

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Aug 16, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Add test case to demo the fix. Basically it will panic because the functional dependency is wrongly derived. The output size of the fd did not match the expected input size to the project plan.

That's because the fd previously is just a clone of the lhs. This PR fixes it.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Aug 16, 2024
@kwannoel kwannoel force-pushed the kwannoel/approx-percentile-fix branch from 642b732 to b3dad06 Compare August 16, 2024 14:44
@kwannoel kwannoel changed the title fix(stream): fix(stream): fix functional dependencies for row merge Aug 16, 2024
@kwannoel kwannoel marked this pull request as ready for review August 16, 2024 14:44
@kwannoel kwannoel requested review from chenzl25 and stdrc August 16, 2024 14:45
Copy link
Member

@stdrc stdrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamp

@kwannoel kwannoel added this pull request to the merge queue Aug 17, 2024
Merged via the queue into main with commit 83b3647 Aug 17, 2024
31 of 32 checks passed
@kwannoel kwannoel deleted the kwannoel/approx-percentile-fix branch August 17, 2024 07:25
github-merge-queue bot pushed a commit that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants