feat(iceberg): Optimization iceberg source count(*) query #18067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xxhZs
changed the title
xxhZs
force-pushed
the
xxh/add-iceberg-count
branch
2 times, most recently
from
0d32982 to
2552e1f
Compare
xxhZs
force-pushed
the
xxh/add-iceberg-count
branch
from
2552e1f to
ae95e1e
Compare
chenzl25
reviewed
Aug 19, 2024
Comment on lines
+61
to
+72
| enum SourceType { | ||
| UNSPECIFIED = 0; | ||
| SCAN = 1; | ||
| COUNT_STAR = 2; | ||
| } | ||
| uint32 source_id = 1; | ||
| repeated plan_common.ColumnCatalog columns = 2; | ||
| map<string, string> with_properties = 3; | ||
| repeated bytes split = 4; | ||
| catalog.StreamSourceInfo info = 5; | ||
| map<string, secret.SecretRef> secret_refs = 6; | ||
| SourceType source_type = 7; |
There was a problem hiding this comment.
I think this new field is too special to be a part of the SourceNode proto because it only meaningful for iceberg. Considering we will try to support predicate pushdown for iceberg scan, I think we can separate iceberg scan from source node just like file scan.
| @@ -196,49 +199,81 @@ pub enum IcebergTimeTravelInfo { | |||
| } | |||
|
|
|||
| impl IcebergSplitEnumerator { | |||
| pub async fn list_splits_batch( | |||
| pub async fn list_splits_batch_count_star( | |||
There was a problem hiding this comment.
If it is a count star query, we don't need to return multiple splits, i.e. we don't need to run it in a distributed way.
| use crate::error::BatchError; | ||
| use crate::executor::{DataChunk, Executor}; | ||
|
|
||
| pub struct IcebergCountStarExecutor { |
There was a problem hiding this comment.
It seems we don't even need a special iceberg count start executor, ValuesExecutor can be used instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
#17958
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.