feat(compactor): compaction iterator support filter key with key_range #18031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto li0k/compactor_iter_key_range
hzxa21
approved these changes
Aug 20, 2024
Comment on lines
+291
to
+304
| assert!( | ||
| !self.exceed_key_range_left(key), | ||
| "key {:?} key_range_left {:?}", | ||
| key, | ||
| self.key_range_left.to_ref() | ||
| ); | ||
|
|
||
| assert!( | ||
| !self.exceed_key_range_right(key), | ||
| "key {:?} key_range_right {:?} key_range_right_exclusive {}", | ||
| key, | ||
| self.key_range_right.to_ref(), | ||
| self.key_range_right_exclusive | ||
| ); |
There was a problem hiding this comment.
Should this be debug_assert?
There was a problem hiding this comment.
For performance.
I think so.
For data correctness.
I think it has to be assert, when the key doesn't satisfy this condition we may give wrong output, and it can't be assumed that the user must have used FullKeyTracker externally to judge the output.
what do you think @hzxa21
hzxa21
reviewed
Aug 20, 2024
…nto li0k/compactor_iter_key_range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
part 2 of #17898
After PR 17898, SstableStreamIterator will no longer read the whole object, it needs to filter block_metas and keys by key_range to ensure that the k-v pair read belongs to the current SST.
Note: This PR does not implement the logic for fast_compact.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.