-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cdc): rate limit for cdc backfill #17989
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work! Could you add e2e_source_test for cdc backfill?
You can reuse the test logic under https://github.com/risingwavelabs/risingwave/blob/main/e2e_test/source/basic/alter/rate_limit_table_kafka.slt.
See that we can set cdc_backfill
to 0 initially, and alter it to resume.
Rest LGTM |
da01704
to
840aacd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Support
alter table t1 set backfill_rate_limit = xx
for cdc table.update_mv_rate_limit_by_table_id
to modify therate_limit
ofStreamCdcScan
nodeTested locally.
#17913
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
Support altering
backfill_rate_limit
of cdc table.