Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdc): rate limit for cdc backfill #17989

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Conversation

StrikeW
Copy link
Contributor

@StrikeW StrikeW commented Aug 9, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Support alter table t1 set backfill_rate_limit = xx for cdc table.

  • Extend update_mv_rate_limit_by_table_id to modify the rate_limit of StreamCdcScan node

Tested locally.

#17913

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

Support altering backfill_rate_limit of cdc table.

@StrikeW StrikeW marked this pull request as ready for review August 9, 2024 15:06
@StrikeW StrikeW added the user-facing-changes Contains changes that are visible to users label Aug 12, 2024
Copy link
Contributor

@kwannoel kwannoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! Could you add e2e_source_test for cdc backfill?

You can reuse the test logic under https://github.com/risingwavelabs/risingwave/blob/main/e2e_test/source/basic/alter/rate_limit_table_kafka.slt.

See that we can set cdc_backfill to 0 initially, and alter it to resume.

@kwannoel
Copy link
Contributor

Rest LGTM

@StrikeW StrikeW force-pushed the siyuan/cdc-backfill-rate-limit branch from da01704 to 840aacd Compare August 12, 2024 02:12
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kwannoel kwannoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@graphite-app graphite-app bot requested a review from a team August 14, 2024 02:52
@StrikeW StrikeW added this pull request to the merge queue Aug 14, 2024
Merged via the queue into main with commit 3a856bb Aug 14, 2024
33 of 34 checks passed
@StrikeW StrikeW deleted the siyuan/cdc-backfill-rate-limit branch August 14, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants