Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stream): let Row Merge executor handle extra row count column in input #17978

Merged
merged 4 commits into from
Aug 11, 2024

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Aug 8, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Row Count column will not have a corresponding mapping in the i2o map. So if we chance upon a column without a mapping, we can just ignore it.

Also added a test for approx percentile mixed with normal agg. Subsequent PR will also add support for stateful agg e.g. min/max.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@kwannoel kwannoel requested review from stdrc, chenzl25 and st1page August 8, 2024 16:26
@github-actions github-actions bot added the type/fix Bug fix label Aug 8, 2024
@kwannoel kwannoel force-pushed the kwannoel/approx-percentile-merge-normal branch from df35baf to 83d7dcb Compare August 9, 2024 05:27
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwannoel kwannoel force-pushed the kwannoel/approx-percentile-merge-normal branch from 83d7dcb to ff45bd9 Compare August 10, 2024 06:49
@graphite-app graphite-app bot requested a review from a team August 10, 2024 07:18
@kwannoel kwannoel added this pull request to the merge queue Aug 11, 2024
Merged via the queue into main with commit a8b2811 Aug 11, 2024
29 of 30 checks passed
@kwannoel kwannoel deleted the kwannoel/approx-percentile-merge-normal branch August 11, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants