Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(meta): simplify InflightActorInfo and extract InflightGraphInfo #17956

Merged
merged 6 commits into from
Aug 9, 2024

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Aug 7, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Previously, we include many inflight status of the running streaming graph in InflightActorInfo. In #17735 where we may have multiple partial graphs, we will assign a such struct to each partial graph to track their inflight statuses. Therefore, the InflightActorInfo will rename to InflightGraphInfo, and two global info fields, node_map and mv_depended_subscriptions, will be removed from the struct. The node_map will be discarded, and we will change to use the node_map stored in ActiveStreamingWorker. The mv_depended_subscriptions will be maintained separately in a newly introduced struct InflightSubscriptionInfo.

In CommandContext, we won't hold the InflightActorInfo any more. We will instead just hold its fields that we will previously access from CommandContext.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wenym1 wenym1 added this pull request to the merge queue Aug 9, 2024
Merged via the queue into main with commit cc21a6a Aug 9, 2024
30 of 31 checks passed
@wenym1 wenym1 deleted the yiming/extract-graph-info branch August 9, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants