-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(risedev): introduce sql server to risedev #17951
Conversation
|
||
fn envs(&self) -> Vec<(String, String)> { | ||
vec![ | ||
("ACCEPT_EULA".to_owned(), "Y".to_owned()), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By passing the value "Y" to the environment variable "ACCEPT_EULA", you are expressing that you have a valid and existing license for the edition and version of SQL Server that you intend to use. You also agree that your use of SQL Server software running in a Docker container image will be governed by the terms of your SQL Server license.
https://arc.net/l/quote/uetmwpuy
🤔 Looks dangerous
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, developer edition (the default) looks OK.
SQL Server Developer edition lets developers build any kind of application on top of SQL Server. It includes all the functionality of Enterprise edition, but is licensed for use as a development and test system, not as a production server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can we change the e2e tests to use risedev? i.e., add to ci-inline-source-test
profile, and only let this section to handle it.
risingwave/ci/scripts/e2e-source-test.sh
Lines 38 to 41 in 63801dd
echo "--- e2e, inline test" | |
RUST_LOG="debug,risingwave_stream=info,risingwave_batch=info,risingwave_storage=info" \ | |
risedev ci-start ci-inline-source-test | |
risedev slt './e2e_test/source_inline/**/*.slt' |
cacd0da
to
3fa8335
Compare
Do you mean moving cdc source tests to |
Yes. Also remove |
Currently, the cdc source tests include recovery tests. When we support recovery in |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
as titled.
An example:
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.