Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(risedev): introduce sql server to risedev #17951

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

KeXiangWang
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

as titled.

An example:

      - use: sqlserver
        # user-managed: true
        address: localhost
        port: 1433
        user: SA
        password: "YourPassword123"
        database: "master"

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.


fn envs(&self) -> Vec<(String, String)> {
vec![
("ACCEPT_EULA".to_owned(), "Y".to_owned()),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By passing the value "Y" to the environment variable "ACCEPT_EULA", you are expressing that you have a valid and existing license for the edition and version of SQL Server that you intend to use. You also agree that your use of SQL Server software running in a Docker container image will be governed by the terms of your SQL Server license.

https://arc.net/l/quote/uetmwpuy

🤔 Looks dangerous

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, developer edition (the default) looks OK.

SQL Server Developer edition lets developers build any kind of application on top of SQL Server. It includes all the functionality of Enterprise edition, but is licensed for use as a development and test system, not as a production server.

Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we change the e2e tests to use risedev? i.e., add to ci-inline-source-test profile, and only let this section to handle it.

echo "--- e2e, inline test"
RUST_LOG="debug,risingwave_stream=info,risingwave_batch=info,risingwave_storage=info" \
risedev ci-start ci-inline-source-test
risedev slt './e2e_test/source_inline/**/*.slt'

@KeXiangWang KeXiangWang force-pushed the wkx/support-sql-server-in-risedev branch from cacd0da to 3fa8335 Compare August 7, 2024 21:16
@KeXiangWang
Copy link
Contributor Author

LGTM. Can we change the e2e tests to use risedev? i.e., add to ci-inline-source-test profile, and only let this section to handle it.

Do you mean moving cdc source tests to e2e_test/source_inline?

@xxchan
Copy link
Member

xxchan commented Aug 8, 2024

LGTM. Can we change the e2e tests to use risedev? i.e., add to ci-inline-source-test profile, and only let this section to handle it.

Do you mean moving cdc source tests to e2e_test/source_inline?

Yes. Also remove export in e2e-source-test.sh

@KeXiangWang
Copy link
Contributor Author

Yes. Also remove export in e2e-source-test.sh

Currently, the cdc source tests include recovery tests. When we support recovery in slt, we can do it and it should be a separate PR.

@xxchan xxchan added this pull request to the merge queue Aug 9, 2024
Merged via the queue into main with commit d00e2eb Aug 9, 2024
29 of 30 checks passed
@xxchan xxchan deleted the wkx/support-sql-server-in-risedev branch August 9, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants