Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sink): support shared tree for clickhouse #17919

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Conversation

xxhZs
Copy link
Contributor

@xxhZs xxhZs commented Aug 5, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

support shared tree for clickhouse, and it is a paid future

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxhZs xxhZs requested review from hzxa21, lmatz and wenym1 August 5, 2024 08:32
@lmatz
Copy link
Contributor

lmatz commented Aug 5, 2024

wonder if it is tested with clickhouse cloud? It has a 30-day trial and does not require credit info

Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xxhZs
Copy link
Contributor Author

xxhZs commented Aug 6, 2024

wonder if it is tested with clickhouse cloud? It has a 30-day trial and does not require credit info

Tested basic functionality, no problems

@lmatz lmatz added the need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged label Aug 6, 2024
@xxhZs xxhZs enabled auto-merge August 6, 2024 03:03
@xxhZs xxhZs added this pull request to the merge queue Aug 6, 2024
Merged via the queue into main with commit ecc8447 Aug 6, 2024
29 of 30 checks passed
@xxhZs xxhZs deleted the xxh/clikchouse-shared-tree branch August 6, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants