feat(sink): add check license for snowflake, dynamodb opensearch sink #17912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
reviewed
Aug 5, 2024
Comment on lines
173
to
177
| if connector == SnowflakeSink::SINK_NAME { | ||
| risingwave_common::license::Feature::SnowflakeSink | ||
| .check_available() | ||
| .map_err(|e| RwError::from(ErrorCode::SinkError(anyhow::Error::from(e).into())))?; | ||
| } |
There was a problem hiding this comment.
You may consider adding the checker in
async fn validate(&self) -> Result<()> {If I understand correctly, this is the right place for adding checker for sinks.
lmatz
approved these changes
Aug 13, 2024
There was a problem hiding this comment.
LGTM from the test cases
cc: @xiangjinwu if there is any other concern?
BugenZhao
approved these changes
Aug 13, 2024
|
cc: @xxhZs could you resolve the conflicts? The license is expected to be enforced in the first candidate release of 2.0. Code freeze on 8/15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
as title
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.