Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sink_bench): Fix cargo build warn #17894

Merged
merged 5 commits into from
Aug 1, 2024
Merged

fix(sink_bench): Fix cargo build warn #17894

merged 5 commits into from
Aug 1, 2024

Conversation

xxhZs
Copy link
Contributor

@xxhZs xxhZs commented Aug 1, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

in #17463
we add plotlib , But its dependency on svg leads to warn, and the library lacks maintenance.
So we use replace plotlib with plotters

#17783

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxhZs xxhZs requested a review from a team as a code owner August 1, 2024 08:35
@xxhZs xxhZs requested review from stdrc, fuyufjh and wenym1 August 1, 2024 08:35
@github-actions github-actions bot added the type/fix Bug fix label Aug 1, 2024
@xxhZs xxhZs requested a review from xiangjinwu August 1, 2024 08:35
@xxhZs xxhZs changed the title fix(build): Fix cargo build warn fix(cargo): Fix cargo build warn Aug 1, 2024
@xxhZs xxhZs changed the title fix(cargo): Fix cargo build warn fix(sink_bench): Fix cargo build warn Aug 1, 2024
Copy link
Contributor

@wenym1 wenym1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally. The warning is gone. Thanks for the fix!

Copy link
Member

@stdrc stdrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on behalf of cargo-lock

@@ -25,7 +25,7 @@ itertools = { workspace = true }
libc = "0.2"
opentelemetry = { workspace = true, optional = true }
parking_lot = { workspace = true }
plotlib = "0.5.1"
plotters = {version = "0.3.5", default-features = false, features = ["svg_backend","line_series","point_series"]}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
plotters = {version = "0.3.5", default-features = false, features = ["svg_backend","line_series","point_series"]}
plotters = { version = "0.3.5", default-features = false, features = [
"svg_backend",
"line_series",
"point_series",
] }

@xxhZs xxhZs enabled auto-merge August 1, 2024 09:29
@xxhZs xxhZs added this pull request to the merge queue Aug 1, 2024
Merged via the queue into main with commit 42cdbf3 Aug 1, 2024
29 of 30 checks passed
@xxhZs xxhZs deleted the xxh/fix-build-warn branch August 1, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants