-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sink_bench): Fix cargo build warn #17894
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified locally. The warning is gone. Thanks for the fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on behalf of cargo-lock
src/bench/Cargo.toml
Outdated
@@ -25,7 +25,7 @@ itertools = { workspace = true } | |||
libc = "0.2" | |||
opentelemetry = { workspace = true, optional = true } | |||
parking_lot = { workspace = true } | |||
plotlib = "0.5.1" | |||
plotters = {version = "0.3.5", default-features = false, features = ["svg_backend","line_series","point_series"]} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plotters = {version = "0.3.5", default-features = false, features = ["svg_backend","line_series","point_series"]} | |
plotters = { version = "0.3.5", default-features = false, features = [ | |
"svg_backend", | |
"line_series", | |
"point_series", | |
] } |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
in #17463
we add plotlib , But its dependency on svg leads to warn, and the library lacks maintenance.
So we use replace plotlib with plotters
#17783
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.