Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(standalone): write risedev-env file in standalone mode #17870

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

BugenZhao
Copy link
Member

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Resolve #17090.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@BugenZhao BugenZhao requested review from xxchan and kwannoel July 30, 2024 09:45
@github-actions github-actions bot added the type/fix Bug fix label Jul 30, 2024
Copy link
Contributor

@kwannoel kwannoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@kwannoel
Copy link
Contributor

We can test if it works by replacing single-node's adhoc writing of the risedev-env file, inside run-e2e-test.sh.

@BugenZhao
Copy link
Member Author

We can test if it works by replacing single-node's adhoc writing of the risedev-env file, inside run-e2e-test.sh.

Updated. Thanks for the reminder.

Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

Signed-off-by: Bugen Zhao <[email protected]>
@graphite-app graphite-app bot requested a review from a team July 31, 2024 06:55
@BugenZhao BugenZhao added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit db29442 Jul 31, 2024
29 of 30 checks passed
@BugenZhao BugenZhao deleted the bz/standalone-risedev-dev-again branch July 31, 2024 07:50
@@ -5,6 +5,7 @@ set -euo pipefail
export RW_PREFIX=$PWD/.risingwave
export PREFIX_BIN=./target/debug
export PREFIX_LOG=$RW_PREFIX/log
export RISEDEV=1 # as if we are running in RiseDev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PREFIX_CONFIG is not set

@xxchan xxchan mentioned this pull request Aug 1, 2024
9 tasks
@xxchan
Copy link
Member

xxchan commented Aug 1, 2024

🤪
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot ./risedev slt after ./risedev p since we forward impl to standalone
3 participants