Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the log suppression for join amplification #17861

Merged
merged 2 commits into from
Jul 31, 2024
Merged

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Jul 30, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Resolves #17858. See background there.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@fuyufjh fuyufjh requested review from kwannoel and zwang28 July 30, 2024 05:39
@fuyufjh fuyufjh marked this pull request as ready for review July 30, 2024 05:39
@github-actions github-actions bot added the type/fix Bug fix label Jul 30, 2024
@fuyufjh fuyufjh enabled auto-merge July 30, 2024 07:45
@fuyufjh fuyufjh added this pull request to the merge queue Jul 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 30, 2024
@fuyufjh fuyufjh added this pull request to the merge queue Jul 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 30, 2024
@fuyufjh fuyufjh added this pull request to the merge queue Jul 31, 2024
Merged via the queue into main with commit 2c23809 Jul 31, 2024
29 of 30 checks passed
@fuyufjh fuyufjh deleted the eric/17858 branch July 31, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

log: helpful logs may be suppressed
4 participants