Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(telemetry): support report event to telemetry (#17486) #17835

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

tabVersion
Copy link
Contributor

@tabVersion tabVersion commented Jul 29, 2024

Signed-off-by: tabVersion [email protected]
Signed-off-by: tabversion [email protected]
Co-authored-by: tabversion [email protected]I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

resolve #17834

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

tabVersion and others added 2 commits July 29, 2024 11:01
Signed-off-by: tabVersion <[email protected]>
Signed-off-by: tabversion <[email protected]>
Co-authored-by: tabversion <[email protected]>
Signed-off-by: tabVersion <[email protected]>
@tabVersion tabVersion requested a review from a team as a code owner July 29, 2024 03:24
@tabVersion tabVersion requested review from xiangjinwu and removed request for a team July 29, 2024 03:24
Copy link
Contributor

@huangjw806 huangjw806 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@huangjw806 huangjw806 requested a review from lmatz July 29, 2024 03:27
@tabVersion tabVersion enabled auto-merge July 29, 2024 03:29
@tabVersion tabVersion added this pull request to the merge queue Jul 29, 2024
Merged via the queue into release-1.10 with commit 9f3af5a Jul 29, 2024
30 of 31 checks passed
@tabVersion tabVersion deleted the tab/cherry-pick-event branch July 29, 2024 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants