Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ca option for schema registry #17826

Closed
wants to merge 7 commits into from
Closed

Conversation

tabVersion
Copy link
Contributor

@tabVersion tabVersion commented Jul 26, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

as title, allow to config a ca cert option when making HTTP request

resolve #17173

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

add a new schema registry option schema.registry.ca (optional)

allowed value: 'ignore' and ''

...
FORMAT PLAIN ENCODE AVRO (
  schema.registry = 'http:// ...',
  schema.registry.username = 'username',
  schema.registry.password = 'password',
  schema.registry.ca = '/root/ca.cert' -- or 'ignore'
)

it can also work with secret management

FORMAT PLAIN ENCODE AVRO (
  schema.registry = 'http:// ...',
  schema.registry.username = 'username',
  schema.registry.password = 'password',
  schema.registry.ca = SECRET custom_ca AS FILE
)

Signed-off-by: tabVersion <[email protected]>
Copy link

gitguardian bot commented Jul 26, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9425213 Triggered Generic Password ed20182 ci/scripts/e2e-source-test.sh View secret
8739168 Triggered Username Password aca4c70 src/connector/src/schema/schema_registry/client.rs View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@graphite-app graphite-app bot requested a review from a team July 30, 2024 09:22
@tabVersion tabVersion marked this pull request as draft July 30, 2024 09:22
@tabVersion
Copy link
Contributor Author

tabVersion commented Aug 8, 2024

giving up now, really cannot build a test env for it.
The pr can work in theory. May consider merging it when meeting a real case.

@tabVersion tabVersion marked this pull request as ready for review August 8, 2024 08:06
@tabVersion tabVersion marked this pull request as draft August 11, 2024 15:04
Copy link
Contributor

This PR has been open for 60 days with no activity.

If it's blocked by code review, feel free to ping a reviewer or ask someone else to review it.

If you think it is still relevant today, and have time to work on it in the near future, you can comment to update the status, or just manually remove the no-pr-activity label.

You can also confidently close this PR to keep our backlog clean. (If no further action taken, the PR will be automatically closed after 7 days. Sorry! 🙏)
Don't worry if you think the PR is still valuable to continue in the future.
It's searchable and can be reopened when it's time. 😄

@tabVersion
Copy link
Contributor Author

close for lacking test env

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSL configurations is not supported for schema registry
2 participants