Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(secret): license the secret management feature #17823

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

yuhao-su
Copy link
Contributor

@yuhao-su yuhao-su commented Jul 26, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Require paid tier for secret management feature. Only disallow create/drop secret when unlicensed.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we also check the license when using (inlining) an existing secret?

src/license/src/feature.rs Outdated Show resolved Hide resolved
@yuhao-su
Copy link
Contributor Author

yuhao-su commented Jul 26, 2024

Shall we also check the license when using (inlining) an existing secret?

We can. It really depends on what error message we want to show.

Also should we allow users to use secrets created when they are licensed and just disallow any creating new secrets? cc @neverchanje


After some discussion, we decide to only disallow unlicensed user create/drop secret.

@graphite-app graphite-app bot requested a review from xxchan July 26, 2024 08:54
@yuhao-su yuhao-su requested a review from BugenZhao July 29, 2024 08:57
src/license/src/feature.rs Outdated Show resolved Hide resolved
@yuhao-su yuhao-su requested a review from BugenZhao July 29, 2024 09:18
@yuhao-su yuhao-su enabled auto-merge July 29, 2024 09:24
@yuhao-su yuhao-su added this pull request to the merge queue Jul 29, 2024
Merged via the queue into main with commit d292e14 Jul 29, 2024
29 of 30 checks passed
@yuhao-su yuhao-su deleted the yuhao/license-secret-feature branch July 29, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants