Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): support extended query for cursor #17821

Merged
merged 10 commits into from
Aug 9, 2024
Merged

Conversation

xxhZs
Copy link
Contributor

@xxhZs xxhZs commented Jul 26, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Previously, we didn't support fetch cursor with extendend mode, this pr supports it

We've done some refactoring of the subscription cursor

  1. When the cursor is created, we use a table to specify a shcema , and then when we fetch, if the shcema result is different from old, we update the shcema and return null to avoid inconsistencies between the schema and the row.
  2. When the cursor is created, we create the row_stream with the default formats, but we don't consume it, we only refill and consume it when fetch inputs the correct formats

#17716

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

Can delete unsupported extendend query mode

@graphite-app graphite-app bot requested a review from xxchan July 29, 2024 05:41
@xxhZs xxhZs force-pushed the xxh/fix-subscription-jdbc branch from 2e3f830 to 681dac6 Compare August 1, 2024 06:09
@xxhZs xxhZs requested a review from hzxa21 August 6, 2024 06:41
@xxhZs xxhZs added this pull request to the merge queue Aug 9, 2024
Merged via the queue into main with commit efdbf3c Aug 9, 2024
30 of 31 checks passed
@xxhZs xxhZs deleted the xxh/fix-subscription-jdbc branch August 9, 2024 08:39
@hzxa21 hzxa21 changed the title feat(frontend): support extendend query for cursor feat(frontend): support extended query for cursor Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants