fix(dyn-filter): filter left changes according to watermark before writing state table #17816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
9 tasks
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
This stack of pull requests is managed by Graphite. Learn more about stacking. |
stdrc
commented
Aug 1, 2024
Comment on lines
+101
to
+106
| ExprType::LessThan | ExprType::LessThanOrEqual => { | ||
| // For <= and <, watermark on rhs means all rows older than the watermark should already be emitted, | ||
| // and future lhs inputs should be directly passed to downstream without any state table operation. | ||
| // So, the state table can be cleaned up. | ||
| true | ||
| } |
There was a problem hiding this comment.
Now the left table is cleaned by rhs watermark when comparator is < and <= as well.
stdrc
commented
Aug 1, 2024
| // that has been applied to the state table, just like why we use `prev_epoch_value` | ||
| // instead of `current_epoch_value` for `filter_condition`. | ||
| let below_watermark_condition = | ||
| build_cond(LessThan, self.left_table.get_committed_watermark().cloned()) |
There was a problem hiding this comment.
Thanks to the removal of "state clean watermark buffer", now we can get up-to-date committed watermark from state table (and even after recovery).
9 tasks
Signed-off-by: Richard Chien <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
After #17767, we can get persisted watermark value for each vnode in state table. This PR utilizes this feature to filter out changes that are below committed table watermark before writing into state table. This fixes #17711.
close #14014
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.