fix(postgres-cdc): only prepare statement in the backfill process #17813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
StrikeW
changed the title
StrikeW
added
the
need-cherry-pick-release-1.10
fuyufjh
reviewed
Jul 26, 2024
| Self::filter_expression(&primary_keys), | ||
| order_key, | ||
| ); | ||
| client.prepare(&scan_sql).await? |
There was a problem hiding this comment.
Every time it prepares once and execute once? Then let's just use simple statements such as Line 406~413
There was a problem hiding this comment.
prepare for each scan_limit chunk, we need the data type from upstream to convert varchar for uuid.
line 398.
There was a problem hiding this comment.
Can we make it prepare once but only when backfill not finished yet?
There was a problem hiding this comment.
It is possible, but needs to refactor the code for example to call a init method before doing the snapshot.
We have set the default value of scan_limit to 1000, the overhead is low.
fuyufjh
approved these changes
Jul 26, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
…7813) (#17827) Co-authored-by: StrikeW <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.