Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metrics): deprecate executor identity in sink metrics #17810

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Jul 25, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Resolves #17532.

"Executor identity" is less informative for monitoring. In this PR, we use actor_id as a substitute of executor_id to distinguish multiple parallelism of the SinkExecutor, and add sink_name to make it more friendly to users.

Screenshots image image image image

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@fuyufjh fuyufjh requested review from chenzl25 and wenym1 July 25, 2024 06:12
@github-actions github-actions bot added the type/fix Bug fix label Jul 25, 2024
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fuyufjh fuyufjh added this pull request to the merge queue Jul 25, 2024
Copy link
Contributor

@wenym1 wenym1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 25, 2024
@fuyufjh fuyufjh added this pull request to the merge queue Jul 25, 2024
Merged via the queue into main with commit 1b77066 Jul 25, 2024
30 of 31 checks passed
@fuyufjh fuyufjh deleted the eric/deprecate_executor_identity_in_sink_metrics branch July 25, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

grafana: Use human-readable sink name instead of executor id
3 participants