Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use separate configuration for exchange connection pool for batch and streaming (#17768) #17808

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Jul 25, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Closes #17804.

cherrypick #17768 into release-1.10

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@kwannoel kwannoel requested a review from a team as a code owner July 25, 2024 02:52
@kwannoel kwannoel requested a review from lmatz July 25, 2024 02:52
@graphite-app graphite-app bot requested a review from a team July 25, 2024 02:52
@kwannoel kwannoel changed the base branch from main to release-1.10 July 25, 2024 02:52
@kwannoel kwannoel force-pushed the kwannoel/cherry-pick-1.10 branch from 7fbede3 to 18eddaa Compare July 25, 2024 02:57
@kwannoel kwannoel changed the title Kwannoel/cherry pick 1.10 refactor: use separate configuration for exchange connection pool for batch and streaming (#17768) Jul 25, 2024
@kwannoel kwannoel requested review from BugenZhao and zwang28 July 25, 2024 02:58
@kwannoel kwannoel added this pull request to the merge queue Jul 25, 2024
Merged via the queue into release-1.10 with commit b50d334 Jul 25, 2024
40 of 41 checks passed
@kwannoel kwannoel deleted the kwannoel/cherry-pick-1.10 branch July 25, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants