-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Improve wording of error message #17766
Merged
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
5b187ea
grammar check
WanYixian b0b0c2b
second batch
WanYixian d97af61
Update java/connector-node/risingwave-sink-cassandra/src/main/java/co…
WanYixian ed4f43c
Update java/connector-node/risingwave-sink-cassandra/src/main/java/co…
WanYixian d5db69e
Update java/connector-node/risingwave-sink-cassandra/src/main/java/co…
WanYixian 6722b46
Update java/connector-node/risingwave-sink-cassandra/src/main/java/co…
WanYixian d0338e9
Update java/connector-node/risingwave-sink-mock-flink/risingwave-sink…
WanYixian 2372eaf
Update java/connector-node/risingwave-sink-mock-flink/risingwave-sink…
WanYixian 9c0c7ab
Update src/connector/src/sink/big_query.rs
WanYixian fa4e46a
Update src/connector/src/sink/big_query.rs
WanYixian 208af72
Update src/connector/src/sink/deltalake.rs
WanYixian e82c7b6
Update src/connector/src/sink/iceberg/mod.rs
WanYixian 5a75d92
Update src/connector/src/sink/mqtt.rs
WanYixian b94727e
Update src/connector/src/sink/mqtt.rs
WanYixian aeffaa7
Update src/connector/src/sink/mqtt.rs
WanYixian d8f24c7
Update src/connector/src/sink/nats.rs
WanYixian a99825c
Update src/connector/src/sink/nats.rs
WanYixian b9d07a8
fix cargo fmt
fuyufjh e488513
Merge remote-tracking branch 'origin/main' into wyx/review-error-message
fuyufjh c00d8fa
spotless apply
fuyufjh ef2f7fa
fix an error message
fuyufjh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -403,8 +403,8 @@ impl<S: StateStore, const USE_WATERMARK_CACHE: bool> DynamicFilterExecutor<S, US | |
let (range, _latest_is_lower, is_insert) = self.get_range(&curr, prev); | ||
|
||
if !is_insert && self.condition_always_relax { | ||
bail!("The optimizer inferred that the right side's change always make the condition more relaxed.\ | ||
But the right changes make the conditions stricter."); | ||
bail!("The optimizer incorrectly assumed that changes on the right side always relax the condition.\ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's a bit hard to understand this message. |
||
But they actually make it stricter."); | ||
} | ||
|
||
let range = (Self::to_row_bound(range.0), Self::to_row_bound(range.1)); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.