Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(types): simplify ArrayImpl::from_protobuf #17763

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Jul 22, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Previously, we have read_one_value_array, which is basically the same as read_numeric_array. They can be unified into read_primitive_array
  • The bound ValueReader seems unnecessary. Replaced with a method on the Scalar

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

xxchan commented Jul 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @xxchan and the rest of your teammates on Graphite Graphite

@xxchan xxchan marked this pull request as ready for review July 22, 2024 01:00
@graphite-app graphite-app bot requested a review from a team July 22, 2024 01:20
@xxchan xxchan added this pull request to the merge queue Jul 22, 2024
Merged via the queue into main with commit 4f3f7f7 Jul 22, 2024
33 of 34 checks passed
@xxchan xxchan deleted the 07-20-refactor_types_simplify_arrayimpl_from_protobuf branch July 22, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants