refactor(meta): only store CreateStreamingJob command in tracker #17742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like recovery test is failing. Will take a look after it pass. |
…r' into yiming/refactor-create-mv-tracker
The test has passed. It's caused by a bug described in #17613 (comment). @kwannoel PTAL |
kwannoel
reviewed
Jul 19, 2024
| @@ -22,13 +22,16 @@ use crate::barrier::Command; | |||
| use crate::manager::{ActiveStreamingWorkerNodes, ActorInfos, InflightFragmentInfo, WorkerId}; | |||
| use crate::model::{ActorId, FragmentId}; | |||
|
|
|||
| #[derive(Debug, Clone)] | |||
There was a problem hiding this comment.
Can we add some docs for this? Is it for any new fragments associated with the barrier command?
And what is the is_injectable field for, when is it true/false?
There was a problem hiding this comment.
is_injectable means whether we need to inject the barrier directly to the actors of the fragment. The struct is just extracted from the CommandFragmentChanges::NewFragment, and no logic is changed in this PR.
These fragments are the most upstream fragments, such as source, now.
kwannoel
reviewed
Jul 19, 2024
kwannoel
reviewed
Jul 19, 2024
| }, | ||
| &version_stats, | ||
| ) { | ||
| if let Some(command) = tracker.add(&command_ctx, &version_stats) { |
|
Rest LGTM. |
kwannoel
approved these changes
Jul 19, 2024
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
After #17428, the command finish notifier is removed, and for command other than
CreateStreamingJob, we simply store it the inCreateMviewTrackerand don't do anything on it. Therefore, in this PR, we change to only store theCreateStreamingJobcommand in the tracker.The following refactors are done accordingly or by the way:
CreateStreamingJobto a separate structCreateStreamingJobCommandInfoChecklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.