fix(storage): fix spill table id too strict assertion #17736
Conversation
| @@ -965,7 +965,12 @@ impl UploaderData { | |||
| .map(|task_id| { | |||
| let (sst, spill_table_ids) = | |||
| self.spilled_data.remove(task_id).expect("should exist"); | |||
| assert_eq!(spill_table_ids, table_ids); | |||
There was a problem hiding this comment.
What are spill_table_ids and table_ids referring to in this context?
There was a problem hiding this comment.
spill_table_ids is the involved table ids in a spill task. table_ids is the table ids to be synced.
|
Triggered the main-cron job to run. May wait and see the results first. |
|
Oh this is to fix join amplification. Not the integration scale test. May ignore the main-cron result. |
kwannoel
added
the
need-cherry-pick-release-1.10
wenym1
removed
the
need-cherry-pick-release-1.10
|
No need to cherry-pick to any release. The bug is merged recently. |
|
I'm staying at v1.9.1. Is this fix apply to that version already ? |
It seems that v1.9.1 does not even include the code that introduces the too strict assertion. Did you fail this assertion in your environment? |
|
Exactly, I'm deploying risingwave to my k8s cluster in distributed mode, and today the |
|
Btw, I see we already had release v1.10.0 . |
I just checked the code of v1.10.0, and the failed assertion resolved in this PR had not been included in v1.10.0 either. In the same file there is a similar assertion |
Do you mind opening a bug report issue and fill in the related information as much as possible in the issue template so that we can fix the bug with more context? Thanks! |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Resolve #17734
Update a previous unit test so that the corner case can be covered
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.