fix: all_running_fragment_mappings return result instead of panic #17722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… call in `notification_service`.
shanicky
added
the
need-cherry-pick-release-1.10
yezizp2012
reviewed
Jul 17, 2024
| @@ -197,8 +197,7 @@ impl NotificationServiceImpl { | |||
| match &self.metadata_manager { | |||
| MetadataManager::V1(mgr) => { | |||
| let fragment_guard = mgr.fragment_manager.get_fragment_read_guard().await; | |||
| let worker_slot_mappings = | |||
| fragment_guard.all_running_fragment_mappings().collect_vec(); | |||
| let worker_slot_mappings = fragment_guard.all_running_fragment_mappings()?; | |||
There was a problem hiding this comment.
I would prefer to add a warning and return empty mapping to FE, so that the catalogs can still be visible, dropped, cancelled etc and also be able to queried in singleton.
BugenZhao
reviewed
Jul 17, 2024
| &table_fragments.actor_status, | ||
| fragment.vnode_mapping.as_ref().unwrap(), | ||
| ) | ||
| .inspect_err(|e| tracing::warn!("build mapping failed: {:?}, downgrade to None", e)) |
There was a problem hiding this comment.
Suggested change
| .inspect_err(|e| tracing::warn!("build mapping failed: {:?}, downgrade to None", e)) | |
| .inspect_err(|e| tracing::warn!(error = %e.as_report(), "build mapping failed, downgrade to None")) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.