fix: s3_v2 connector cannot read incremental files #17702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tabVersion <[email protected]>
Signed-off-by: tabVersion <[email protected]>
tabVersion
added
the
need-cherry-pick-release-1.10
tabVersion
added a commit
that referenced
this pull request
Jul 17, 2024
Signed-off-by: tabVersion <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 17, 2024
Signed-off-by: tabVersion <[email protected]>
tabVersion
commented
Aug 13, 2024
Comment on lines
+184
to
+186
| stream.replace_data_stream( | ||
| self.build_chunked_paginate_stream(&source_desc) | ||
| .map_err(StreamExecutorError::from)?, |
There was a problem hiding this comment.
Here is a bug actually. We expect the stream to end so we can replace it with a new one, but after merging the list stream with the barrier one, the merged stream never ends. cc @wcy-fdu
tabVersion
added a commit
that referenced
this pull request
Aug 13, 2024
This reverts commit 45f27dc.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
resolve #17671
as title, the list exec just list the file list once due to wrong impl, here introducing a loop to make it keep listing
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.