refactor(types): doc & refine ToBinary/Text #17697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
9 tasks
xxchan
commented
Jul 16, 2024
| @@ -149,7 +149,7 @@ mod tests { | |||
| use mysql_async::Row as MySqlRow; | |||
| use risingwave_common::catalog::{Field, Schema}; | |||
| use risingwave_common::row::Row; | |||
| use risingwave_common::types::{DataType, ToText}; | |||
| use risingwave_common::types::DataType; | |||
There was a problem hiding this comment.
This change was made during browsing all references of ToText. Don't think it's worth exposing it here.
xiangjinwu
approved these changes
Jul 16, 2024
| @@ -30,14 +33,15 @@ pub enum ToBinaryError { | |||
|
|
|||
| pub type Result<T> = std::result::Result<T, ToBinaryError>; | |||
|
|
|||
| // Used to convert ScalarRef to text format | |||
src/common/src/types/to_text.rs
Outdated
| @@ -18,7 +18,14 @@ use std::num::FpCategory; | |||
| use super::{DataType, DatumRef, ScalarRefImpl}; | |||
| use crate::dispatch_scalar_ref_variants; | |||
|
|
|||
| // Used to convert ScalarRef to text format | |||
| /// Converts `ScalarRef` to text format. | |||
| /// This is the implementation for casting to varchar, and pgwire "TEXT" format. | |||
There was a problem hiding this comment.
This is the implementation for casting to varchar
This is not true for a few cases. The TEXT format for boolean is t / f while they cast to varchar true / false.
https://github.com/postgres/postgres/blob/REL_16_3/src/include/catalog/pg_cast.dat#L438-L439
xxchan
force-pushed
the
07-16-refactor_types_doc_refine_tobinary_text
branch
from
a31225a to
45df1da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.