Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ddl): allow drop generated column in table with schema registry #17689

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

yuhao-su
Copy link
Contributor

@yuhao-su yuhao-su commented Jul 15, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Before this pr, dropping any column from a table with schema registry is not allowed. We loose this constraint here.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Allow drop generated columns from tables with schema registry.

ALTER TABLE t DROP COLUMN gen_col;

LIMITATION
dropping a generated column will also trigger refreshing schema.

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@yuhao-su
Copy link
Contributor Author

Here is a problem: if we drop a generated column, a plan will be re-generated from the SQL definition, which means the schema will also be refreshed since we don't have purified select list. cc. @st1page

@st1page
Copy link
Contributor

st1page commented Jul 23, 2024

Here is a problem: if we drop a generated column, a plan will be re-generated from the SQL definition, which means the schema will also be refreshed since we don't have purified select list. cc. @st1page

Yes, that's a known issue, it will also happen when sink into table. Let's treat it as a separate issue and assume that the external schema (from the schema registry) will not change.

@yuhao-su yuhao-su added the user-facing-changes Contains changes that are visible to users label Jul 23, 2024
@yuhao-su yuhao-su enabled auto-merge July 23, 2024 16:16
@yuhao-su yuhao-su added this pull request to the merge queue Jul 23, 2024
Merged via the queue into main with commit 07bd25b Jul 23, 2024
37 of 38 checks passed
@yuhao-su yuhao-su deleted the yuhao/drop-gencol-in-table-w-sr branch July 23, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants