Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meta): pass streaming error score to meta to locate cluster-level root error #17685

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Jul 15, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Close #17368. Pass streaming error score to meta service to locate cluster-level root error. Instead of concatenating erros from all compute nodes, only show the root error in the recovery reason.

ERROR:  Failed to run the query

Caused by these errors (recent errors listed first):
  1: gRPC request to meta service failed: Internal error
  2: get error from control stream, in worker node 2
  3: gRPC request to stream service failed: Internal error
  4: failed to collect barrier for epoch [6802214756352000]
  5: Actor 13 exited unexpectedly
  6: Executor error
  7: Chunk operation error
  8: Numeric out of range

For implementation: a struct named Extra is added, which can be preserved across the gRPC boundary. The request-provide mechanism of Rust error handling (ref: https://doc.rust-lang.org/stable/std/error/struct.Request.html) is used to embed those extra information with minimal code changes.

Hide the whitespaces for better review experience.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

BugenZhao commented Jul 15, 2024

@BugenZhao BugenZhao marked this pull request as ready for review July 15, 2024 07:35
Base automatically changed from bz/find-root-error-when-inject-failed to main July 16, 2024 03:40
@graphite-app graphite-app bot requested a review from a team July 16, 2024 03:40
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao BugenZhao force-pushed the bz/meta-error-scored branch from 1b4ccf5 to b4ff9d8 Compare July 16, 2024 03:43
Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BugenZhao BugenZhao added this pull request to the merge queue Jul 19, 2024
Merged via the queue into main with commit d0ba17b Jul 19, 2024
31 of 32 checks passed
@BugenZhao BugenZhao deleted the bz/meta-error-scored branch July 19, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pass streaming error score to meta to identify the global-root error
2 participants