Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(source): Avro with AWS Glue Schema Registry (#17605) #17677

Conversation

xiangjinwu
Copy link
Contributor

Cherry picking #17605 onto branch release-1.10\n\nThis PR/issue was created by cherry-pick action from commit 5c52c7d.

@xiangjinwu
Copy link
Contributor Author

https://buildkite.com/risingwavelabs/pull-request/builds/53887#0190a707-97da-42e2-bfe0-bccd67961415

failed to run `e2e_test/source_inline/kafka/avro/glue.slt`
Caused by:
    system command failed: substitution failed: Invalid escape sequence: \n
    [CMD] rpk topic produce -f '%v{hex}\n' 'glue-sample-my-event' <<EOF

Looks like sqllogictest version is incompatible on main and release-1.10

@xxchan
Copy link
Member

xxchan commented Jul 13, 2024

What about cherry-pick #17498 instead 🤡

@xiangjinwu
Copy link
Contributor Author

xiangjinwu commented Jul 13, 2024

What about cherry-pick #17498 instead 🤡

Good point and I guess it also benefits future cherry-picks. There are some trivial textual conflicts #17680 but it may take a little bit more effort (run ci and then fix) to verify if there are more logical conflicts. So I prefer to merge this first and make that as an optional follow-up.

Update: the textual conflicts are due to lack of more dependent version bumps in between (looks like #17397). Not sure if picking this sequence of updates is a good idea ...

@xiangjinwu xiangjinwu added this pull request to the merge queue Jul 16, 2024
Merged via the queue into release-1.10 with commit 0bcb6ab Jul 16, 2024
27 checks passed
@xiangjinwu xiangjinwu deleted the manual-release-1.10-5c52c7d752804e5e0d66b370b7da70a5cd2e8d88 branch July 16, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cherrypick feat(source): Avro with AWS Glue Schema Registry (#17605) to branch release-1.10
3 participants