Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): revert adding hive-exec jar (#17642) #17666

Merged
merged 1 commit into from
Jul 12, 2024
Merged

Conversation

chenzl25
Copy link
Contributor

This reverts commit 5bbb5c8.

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Jul 12, 2024
@chenzl25 chenzl25 enabled auto-merge July 12, 2024 02:49
@chenzl25 chenzl25 added this pull request to the merge queue Jul 12, 2024
Merged via the queue into main with commit c5ab539 Jul 12, 2024
30 of 31 checks passed
@chenzl25 chenzl25 deleted the dylan/revert_17642 branch July 12, 2024 03:00
@wenym1
Copy link
Contributor

wenym1 commented Jul 12, 2024

Any context about this PR?

@fuyufjh
Copy link
Member

fuyufjh commented Jul 17, 2024

Any context about this PR?

It will cause Protobuf conflict

@chenzl25
Copy link
Contributor Author

A new PR which only includes the hive-exec-core, let's see whether it could solve user's issue #17718

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants