Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to openjdk17 for packaging with hdfs #17597

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Jul 8, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

as title, #17013 upgrade the Dockerfile but forget to update the package shell.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@wcy-fdu wcy-fdu requested review from StrikeW and yufansong July 8, 2024 05:38
Copy link
Collaborator

@hzxa21 hzxa21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hzxa21
Copy link
Collaborator

hzxa21 commented Jul 8, 2024

We have been spotted and fixed several bugs and misses in the codes, Dockerfile.hdfs and docker-hdfs.sh. I suspect there will be more. The root cause is because we rely on manual effort to maintain the HDFS related codes and it is hard for developer to remember to update the hdfs related parts during daily development. For example, I saw that the nvm installation is missing in `Dockerfile.hdfs.

Given that we saw more and more requests on HDFS build, I start thinking about the following things:

  1. Shall we have a CI, at least per release, for the hdfs feature?
  2. Based on 1, should we publish a HDFS build image as well for each release?
  3. Should we unify the dockerfile and the build script for HDFS and non-HDFS build given that they share a lot of things in common?

Copy link
Member

@yufansong yufansong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wcy-fdu
Copy link
Contributor Author

wcy-fdu commented Jul 8, 2024

New update:

  • remove atomic_write_dir for hdfs engine.
  • remove --features all-udf as it cause /risingwave/bin/risingwave: error while loading shared libraries: libpython3.12.so.1.0: cannot open shared object file: No such file or directory

cc @hzxa21

@wcy-fdu
Copy link
Contributor Author

wcy-fdu commented Jul 8, 2024

We have been spotted and fixed several bugs and misses in the codes, Dockerfile.hdfs and docker-hdfs.sh. I suspect there will be more. The root cause is because we rely on manual effort to maintain the HDFS related codes and it is hard for developer to remember to update the hdfs related parts during daily development. For example, I saw that the nvm installation is missing in `Dockerfile.hdfs.

Given that we saw more and more requests on HDFS build, I start thinking about the following things:

  1. Shall we have a CI, at least per release, for the hdfs feature?
  2. Based on 1, should we publish a HDFS build image as well for each release?
  3. Should we unify the dockerfile and the build script for HDFS and non-HDFS build given that they share a lot of things in common?

Discussed offline, create an issue to track this.

We have been spotted and fixed several bugs and misses in the codes, Dockerfile.hdfs and docker-hdfs.sh. I suspect there will be more. The root cause is because we rely on manual effort to maintain the HDFS related codes and it is hard for developer to remember to update the hdfs related parts during daily development. For example, I saw that the nvm installation is missing in `Dockerfile.hdfs.

Given that we saw more and more requests on HDFS build, I start thinking about the following things:

  1. Shall we have a CI, at least per release, for the hdfs feature?
  2. Based on 1, should we publish a HDFS build image as well for each release?
  3. Should we unify the dockerfile and the build script for HDFS and non-HDFS build given that they share a lot of things in common?

SGTM, tracked in #17604

@wcy-fdu wcy-fdu enabled auto-merge July 8, 2024 11:29
@wcy-fdu wcy-fdu added this pull request to the merge queue Jul 8, 2024
Merged via the queue into main with commit 10c5aa1 Jul 8, 2024
29 of 30 checks passed
@wcy-fdu wcy-fdu deleted the wcy/enhance_hdfs branch July 8, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants